Add Device Defender Integration Tests #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
integration-tests/source/devicedefender/DeviceDefenderIntegrationTests.cpp
Outdated
Show resolved
Hide resolved
shangabl
force-pushed
the
integration-tests
branch
from
e13e9a7
to
3a4183b
Compare
RogerZhongAWS
previously approved these changes
Jan 4, 2023
RogerZhongAWS
previously approved these changes
Jan 5, 2023
xlcheng1
previously approved these changes
Jan 5, 2023
| criteria.SetDurationSeconds(300); | ||
| criteria.SetValue(metricValue); | ||
| criteria.SetConsecutiveDatapointsToAlarm(1); | ||
| criteria.SetConsecutiveDatapointsToClear(1); |
There was a problem hiding this comment.
do you think this line can be causing any issue? would probably be safer to set this to 100 or something
There was a problem hiding this comment.
I hope that is the issue. Just changed! Thanks!
xlcheng1
previously approved these changes
Jan 6, 2023
shangabl
force-pushed
the
integration-tests
branch
2 times, most recently
from
aca249b
to
d8fc347
Compare
shangabl
force-pushed
the
integration-tests
branch
from
59d9e2e
to
720cf9a
Compare
RogerZhongAWS
previously approved these changes
Jan 11, 2023
xlcheng1
previously approved these changes
Jan 11, 2023
shangabl
force-pushed
the
integration-tests
branch
from
bd0897e
to
f06f16d
Compare
RogerZhongAWS
approved these changes
Jan 12, 2023
xlcheng1
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Change summary
Added Integration tests for DD
Fixed typo in ubi8 docker image tag
Added a Download File integration test for Jobs
Revision diff summary
If there is more than one revision, please explain what has been changed since the last revision.
Testing
Is your change tested? If not, please justify the reason.
Please list your testing steps and test results.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.