Create .gitattributes #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend .gitattributes to use LF not CRLF for bootstrap files
|
Thanks for the PR. I need to find a windows instance to test it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
Create .gitattributes file
I use Windows. I found that when pulling down this repo, the LF characters are changed to CRLF (which is default git behaviour on Windows). This caused a problem with .sh files, since SAM build/deploy does not change CRLF back to LF, and the CRLF causes .sh scripts to fail.
Specifically, I was using the expressjs-zip example, and the error was
/var/task/run.sh: /bin/bash^M: bad interpreter: No such file or directoryThis .gitattribute file tells git not to change LF to CRLF for .sh files. With this file added, syncing the repo and using SAM to build/deploy the expressjs-zip example works correctly.
It also tells git to use LF rather than CRLF for bootstrap files, for the same reason (required for the nginx-zip example).
References:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.