Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http1 support in e2e test request signing #393

Merged
merged 6 commits into from
Feb 22, 2024

Conversation

mxfactorial
Copy link
Contributor

Issue #, if available:

Description of changes:

awslabs/aws-sdk-rust#1041 enables switching apply_to_request_http0x to apply_to_request_http1x

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bnusunny
Copy link
Contributor

Thanks!

Cargo.toml Outdated Show resolved Hide resolved
tests/e2e_tests/util.rs Outdated Show resolved Hide resolved
@bnusunny
Copy link
Contributor

I have a few comments. Could you take a look?

@bnusunny
Copy link
Contributor

And please also fix the lint issue

@mxfactorial
Copy link
Contributor Author

ready

❯ make fmt && make lint && make test
cargo fmt --all -- --check
cargo clippy -- -Dwarnings
    Checking lambda_web_adapter v0.8.1 (/Users/mx/code/aws-lambda-web-adapter)
    Finished dev [unoptimized + debuginfo] target(s) in 0.65s
cargo nextest run
warning: ignoring unknown configuration keys in config file /Users/mx/code/aws-lambda-web-adapter/.config/nextest.toml: profile.ci.inherits
   Compiling lambda_web_adapter v0.8.1 (/Users/mx/code/aws-lambda-web-adapter)
    Finished test [unoptimized + debuginfo] target(s) in 3.13s
    Starting 18 tests across 4 binaries (4 skipped)
        PASS [   0.251s] lambda_web_adapter tests::test_status_200_is_ok
        PASS [   0.249s] lambda_web_adapter tests::test_status_500_is_bad
        PASS [   0.244s] lambda_web_adapter::integ_tests test_http_content_encoding_suffix
        PASS [   0.247s] lambda_web_adapter::integ_tests test_http_basic_request
        PASS [   0.246s] lambda_web_adapter::integ_tests test_http_compress
        PASS [   0.249s] lambda_web_adapter::integ_tests test_adapter_options_from_env
        PASS [   0.245s] lambda_web_adapter::integ_tests test_http_compress_disallowed_type
        PASS [   0.246s] lambda_web_adapter::integ_tests test_http_compress_already_compressed
        PASS [   0.248s] lambda_web_adapter::integ_tests test_adapter_options_from_namespaced_env
        PASS [   0.250s] lambda_web_adapter tests::test_status_403_is_bad_when_configured
        PASS [   0.223s] lambda_web_adapter::integ_tests test_http_context_headers
        PASS [   0.086s] lambda_web_adapter::integ_tests test_http_context_multi_headers
        PASS [   0.070s] lambda_web_adapter::integ_tests test_http_headers
        PASS [   0.086s] lambda_web_adapter::integ_tests test_http_path_encoding
        PASS [   0.069s] lambda_web_adapter::integ_tests test_http_post_put_delete
        PASS [   0.059s] lambda_web_adapter::integ_tests test_http_query_params
        PASS [   0.059s] lambda_web_adapter::integ_tests test_http_readiness_check
        PASS [   0.055s] lambda_web_adapter::integ_tests test_readiness_check_port_fallback_to_lwa_port
------------
     Summary [   0.323s] 18 tests run: 18 passed, 4 skipped

@bnusunny bnusunny merged commit e142eb6 into awslabs:main Feb 22, 2024
23 checks passed
@mxfactorial mxfactorial deleted the http1-dev-dep branch February 23, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants