Extract logic into a library. #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calavera
force-pushed
the
library
branch
2 times, most recently
from
d2eba3a
to
1ebed5a
Compare
This change move the main codebase into a library to help with reusability. This way the adapter can be used independently of the main app. This change also replaces the `log` crate with `tracing`, which is more widely used in the lambda echosystem. Signed-off-by: David Calavera <[email protected]>
|
Thanks very much for refactoring the logic into lib.rs. Just a few minor things to take care of. |
bnusunny
requested changes
Sep 7, 2022
bnusunny
reviewed
Sep 7, 2022
Signed-off-by: David Calavera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the main codebase into a library to help with reusability.
This way the adapter can be used independently of the main app.
This change also replaces the
logcrate withtracing, which is more widely used in the lambda echosystem.Signed-off-by: David Calavera [email protected]
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.