Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First letter in field name changed to lower case #115

Closed
EunGyeongChoe opened this issue Feb 11, 2019 · 2 comments · Fixed by #172
Closed

First letter in field name changed to lower case #115

EunGyeongChoe opened this issue Feb 11, 2019 · 2 comments · Fixed by #172
Assignees
@desokroshan
Labels
bug Something isn't working codegen investigating This issue is being investigated

Comments

@EunGyeongChoe
Copy link

EunGyeongChoe commented Feb 11, 2019 •
edited
Loading

Describe the bug
apollographql/apollo-kotlin#994

If a field name starts with a capital letter then Apollo changes it to a lower case letter. This causes the query or mutation to fail. Changing the function and variable names is just fine, but the marshaller should use a non-modified field name.

A bug has not been fixed in "aws-mobile-appsync-sdk-android"

한국어)
"apollo-android" 에서는 해당 버그가 수정되었으나, "aws-mobile-appsync-sdk-android" 에서는
버그가 남아있습니다.
InputFieldMarshaller 에서 필드명의 첫글자를 소문자로 바꿔버립니다.
@mutablealligator mutablealligator added bug Something isn't working investigating This issue is being investigated AppSync labels Feb 11, 2019
@rohandubal
Copy link
Contributor

@minbi could you please have a look at this issue?

@frankmuellr frankmuellr assigned yuth and unassigned minbi Feb 25, 2019
@devxpy
Copy link

devxpy commented Feb 28, 2019

Wow, this issue single-handedly managed to take down an entire app

@frankmuellr frankmuellr assigned desokroshan and unassigned yuth Apr 19, 2019
@desokroshan desokroshan mentioned this issue May 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@desokroshan desokroshan

Labels
bug Something isn't working codegen investigating This issue is being investigated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix inconsistent capitalization of field names awslabs/aws-mobile-appsync-sdk-android
8 participants
@yuth @desokroshan @minbi @rohandubal @frankmuellr @mutablealligator @devxpy @EunGyeongChoe