Fix inconsistent capitalization of field names #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desokroshan
force-pushed
the
roshan/Issue#115
branch
from
fd5c2c9 to
ff8b91f
Compare
palpatim
approved these changes
May 8, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes : #115
Description of changes:
This PR fixes unwanted de-capitalization of the field names starting with an uppercase letter. We currently do not have unit or integration tests for the compiler module. As an interim test for these code changes, I have capitalized first letter of field
Idfor the input typedeletePostInput. Passing of all the integration tests involvingdeletePostInputvalidates the correctness of the fix.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.