fix bug NPE at ApolloServerInterceptor #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minbi
reviewed
Apr 11, 2019
| callBack.onCompleted(); | ||
| } | ||
| }); | ||
| if (httpCall != null) { |
There was a problem hiding this comment.
Instead of a silent null check can it run the onFailure callback with ApolloNetworkException("Failed to prepare http call, prepared call was null") and return?
There was a problem hiding this comment.
I have amended the callback to return the ApolloNetworkException. Please see commit - 4a2cb0b. Appreciate if you could release this on your side if you are agreeable to this change.
desokroshan
reviewed
Apr 11, 2019
desokroshan
suggested changes
Apr 12, 2019
aws-android-sdk-appsync-api/src/main/java/com/apollographql/apollo/api/InputType.java
Outdated
Show resolved
Hide resolved
...roid-sdk-appsync/src/main/java/com/amazonaws/mobileconnectors/appsync/utils/StringUtils.java
Show resolved
Hide resolved
This reverts commit 15840b7.
minbi
approved these changes
Apr 12, 2019
minbi
added a commit
that referenced
this pull request
Apr 12, 2019
minbi
added a commit
that referenced
this pull request
Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fix potential crash due to NPE at HttpCall object
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.