Resolves uncaught "call is cancelled" subscription exception issue #202 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutablealligator
suggested changes
Oct 14, 2019
...ync-runtime/src/main/java/com/apollographql/apollo/internal/RealAppSyncSubscriptionCall.java
Outdated
Show resolved
Hide resolved
...ync-runtime/src/main/java/com/apollographql/apollo/internal/RealAppSyncSubscriptionCall.java
Outdated
Show resolved
Hide resolved
TrekSoft
force-pushed
the
ddaudeli/issue202
branch
from
9c3de66 to
977d4b3
Compare
TrekSoft
force-pushed
the
ddaudeli/issue202
branch
from
977d4b3 to
5c587fd
Compare
|
All comments resolved and rebased with your CHANGELOG PR which I approved pushed |
mutablealligator
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
[Issue #202]
Description of changes:
Fixes bad runtime exceptions inside a thread with a callback onError wrapping the exception.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.