Implement auto reconnect for WebSocketConnectionManager #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxalbert1996
force-pushed
the
websocket-auto-reconnect
branch
from
cced50b to
8eb5e5d
Compare
|
Just observed this crash (occasionally) when trying to reconnect with no internet access. According to this, it seems that this exception happens when there's no internet connection and needs to be caught manually. Will add that to this PR. |
Comment on lines
+87
to
+88
| final NetworkInfo info = connManager.getActiveNetworkInfo(); | ||
| return info != null && info.isConnected(); |
There was a problem hiding this comment.
This rarely means that there is internet connectivity, unfortunately.
- The active network may be a WiFi network at a coffee shop that imposes a captive portal;
- The active network may be up, but not serving packets.
Consequently, it is better to just try network activities, and if they work, they work, if they fail, do exponential backoff with retries.
There was a problem hiding this comment.
I know that this doesn't necessarily mean there is internet connectivity but there is a chance, so IMHO trying once when a network becomes available doesn't hurt but can dramatically reduce the time needed to resume if there is internet access because of exponential backoff.
There was a problem hiding this comment.
Sounds good. It was also pointed out to me that this is the existing behavior of the non-WebSocket branch, too.
jamesonwilliams
approved these changes
Nov 10, 2020
richardmcclellan
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #317
Description of changes:
Implemented auto reconnect for WebSocket-based subscriptions in WebSocketConnectionManager based on legacy implementation in
RealSubscriptionManager.Also added result check for
WebSocket.send(). This fixes the bug that further subscriptions after theWebSocketListener'sonFailurecallback will fail silently because once failedWebSockets cannot be used any more.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.