Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gradle 7 projects #372

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Add support for Gradle 7 projects #372

merged 1 commit into from
Nov 15, 2021

Conversation

baksansk
Copy link
Contributor

Issue #, if available:
#360

Description of changes:
Gradle 7 requires a property of a task to have an annotation of input/output/internal.
It fails to compile Android projects using Gradle 7 and AGP 7.

This PR adds the @Internal annotation to a private property of ApolloClassGenTask which fixes the compilation error with minimal changes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Gradle 7 requires a property of a task to have an annotation of input/output/internal
Copy link
Contributor

@sdhuka sdhuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdhuka sdhuka merged commit 5768e09 into awslabs:main Nov 15, 2021
@baksansk baksansk deleted the gradle7 branch November 15, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants