feat: port custom domain support. #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poojamat
approved these changes
Dec 10, 2021
raphkim
approved these changes
Dec 10, 2021
div5yesh
reviewed
Dec 10, 2021
...-sdk-appsync/src/test/java/com/amazonaws/mobileconnectors/appsync/AppSyncClientUnitTest.java
Outdated
Show resolved
Hide resolved
div5yesh
reviewed
Dec 10, 2021
| CUSTOM; | ||
|
|
||
| private static final String STANDARD_ENDPOINT_REGEX = | ||
| "^https://\\w{26}\\.appsync-api\\.\\w{2}(?:(?:-\\w{2,})+)-\\d\\.amazonaws.com/graphql$"; |
There was a problem hiding this comment.
Also why \ in \w needs to be escaped?
There was a problem hiding this comment.
Shouldn't
/be escaped?
No, as this is being used for pattern matcher. Here, we are literally looking to match // and hence escaping it would be redundant.
Also why
\in\wneeds to be escaped?
This portion is regex expression and hence we need double backslashes to protect them from being interpreted as escape sequence from the compiler. (\\w will be transformed to \w which is valid regex construct)
div5yesh
approved these changes
Dec 13, 2021
levansang026
pushed a commit
to notabasement/aws-mobile-appsync-sdk-android
that referenced
this pull request
Nov 19, 2022
* feat: port custom domain support. * remove extra space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add the support to custom domain described in aws configuration. Existing functionality of appsync generated domains (with 26 char host) is not changed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.