Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate Nullable annotation #397

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Conversation

tjleing
Copy link
Contributor

@tjleing tjleing commented Jun 9, 2022

Fixes #395. Javapoet v1.11 and higher store annotations on (parameterized) type objects as well as their underlying raw types (i.e. both on List<Item> and Item) so when rebuilding the type we need to clear both.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tjleing tjleing requested a review from a team as a code owner June 9, 2022 20:24
div5yesh
div5yesh previously approved these changes Jun 9, 2022
@tjleing tjleing dismissed stale reviews from div5yesh and sktimalsina via 3d70060 June 9, 2022 20:31
@tjleing tjleing merged commit fb86285 into main Jun 9, 2022
@tjleing tjleing deleted the leint-fix-duplicate-nullable branch June 9, 2022 21:15
levansang026 pushed a commit to notabasement/aws-mobile-appsync-sdk-android that referenced this pull request Nov 19, 2022
* Fix duplicate Nullable annotation

* as? safe cast

Co-authored-by: Thomas Leing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppSync codegen models throws @Nullable @Nullable
5 participants