Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate linter #107

Closed
larryonoff opened this issue Nov 22, 2018 · 4 comments
Closed

Integrate linter #107

larryonoff opened this issue Nov 22, 2018 · 4 comments
Assignees
Labels
feature-request New feature requests

Comments

@larryonoff
Copy link
Contributor

I have suggestion on adding SwiftLint linter to the project, e.g. rules that I'm using in my projects.

disabled_rules: # rule identifiers to exclude from running
  - file_length
  - force_cast
  - function_body_length
  - function_parameter_count
  - large_tuple
  - nesting
  - redundant_optional_initialization
  - type_body_length
  - type_name
  - identifier_name
  - weak_delegate

# configurable rules can be customized from this configuration file
closing_brace: error
comma: error
colon:
  severity: error
empty_count: warning
function_body_length:
  warning: 100
  error: 150
opening_brace: error
return_arrow_whitespace: error
statement_position:
  severity: error
todo: warning
trailing_semicolon: error
@palpatim
Copy link
Contributor

Thanks for this suggestion. We have an internal task to do this as well (it's a pet peeve of mine to not have linted code :) )

We'll be sure to evaluate using your suggested rules above.

@palpatim palpatim self-assigned this Nov 26, 2018
@palpatim palpatim added feature-request New feature requests AppSync labels Nov 26, 2018
@larryonoff
Copy link
Contributor Author

I think it would be great for community to make this as an open PR. I can even start doing it.

@larryonoff
Copy link
Contributor Author

added simple integration #121

@palpatim
Copy link
Contributor

palpatim commented Dec 4, 2018

Merged #121, thanks!

@palpatim palpatim closed this as completed Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature requests
Projects
None yet
Development

No branches or pull requests

2 participants