Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple SwiftLint configuration #121

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Add simple SwiftLint configuration #121

merged 1 commit into from
Dec 4, 2018

Conversation

larryonoff
Copy link
Contributor

Description of changes:

  • add simple SwiftLint configuration
  • fix some linter warnings and errors

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@larryonoff larryonoff mentioned this pull request Dec 4, 2018
Closed
@palpatim palpatim self-requested a review December 4, 2018 17:33
@palpatim palpatim self-assigned this Dec 4, 2018
palpatim
palpatim approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@palpatim palpatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the kick-start. I'm merging this in and will continue by cleaning up some of the remaining warnings and enabling more rules as time goes on.

@palpatim palpatim merged commit a349a15 into awslabs:master Dec 4, 2018
@larryonoff larryonoff deleted the code-cleanup branch December 4, 2018 19:31
@larryonoff
Copy link
Contributor Author

This great news! I think the next step should be integration CI with linter.

@frankmuellr frankmuellr added the contribution Community contribution PRs label Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palpatim palpatim palpatim approved these changes

Assignees

@palpatim palpatim

Labels
contribution Community contribution PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larryonoff @palpatim @frankmuellr