Fix valid architectures #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
added
AppSync
build
|
Good callout, thanks. Testing locally. |
|
Released on 2.9.2 |
larryonoff
added a commit
to larryonoff/aws-mobile-appsync-sdk-ios
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
NA
Description of changes:
Currently for some reason valid architectures are only "armv7 arm64 armv7s", but for example the latest Xcode 10 supports
arm64e. I think that valid architectures should be default that Xcode sets if there're no any specific reasons.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.