Prepopulate records table with empty QUERY_ROOT (#92) #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohandubal
approved these changes
Feb 12, 2019
This was referenced Feb 12, 2019
palpatim
added a commit
that referenced
this pull request
Feb 14, 2019
- Add tests to verify query behavior against different cache-miss conditions, including cache-misses resulting from prepopulating caches with an empty QUERY_ROOT in #177.
palpatim
added a commit
that referenced
this pull request
Feb 14, 2019
- Add tests to verify query behavior against different cache-miss conditions, including cache-misses resulting from prepopulating caches with an empty QUERY_ROOT in #177.
palpatim
added a commit
that referenced
this pull request
Feb 14, 2019
- Added tests to verify query behavior against different cache-miss conditions, including cache-misses resulting from prepopulating caches with an empty QUERY_ROOT in #177.
palpatim
added a commit
that referenced
this pull request
Feb 14, 2019
- Added tests to verify query behavior against different cache-miss conditions, including cache-misses resulting from prepopulating caches with an empty QUERY_ROOT in #177.
palpatim
added a commit
that referenced
this pull request
Feb 14, 2019
- Added tests to verify query behavior against different cache-miss conditions, including cache-misses resulting from prepopulating caches with an empty QUERY_ROOT in #177.
palpatim
added a commit
that referenced
this pull request
Feb 15, 2019
* Resolve cache-miss behavior for AppSync-modified Apollo client - Added tests to verify query behavior against different cache-miss conditions, including cache-misses resulting from prepopulating caches with an empty QUERY_ROOT in #177. * Manually added optionalString to StarWarsAPI.HeroNameQuery selection set Added optionalString to verify that a null optional field will not cause an improper cache miss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#92
Description of changes:
Prepopulated both AWSSQLiteNormalizedCache and InMemoryNormalizedCache with an empty QUERY_ROOT record to allow optimistic updates of empty caches. Works around an Apollo behavior that is arguably a bug, but that I'm reluctant to change for fear of unintended side effects in the rest of the handling. See discussion on #92.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.