-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Subscription status change handler; fix AppSyncMQTTClient data races #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
changed the title
Fixed AppSyncMQTTClient data races (#184)
Add Subscription status change handler; fix AppSyncMQTTClient data races
Mar 8, 2019
- Fixed AppSyncMQTTClient data races (#184) - Added `statusChangeHandler` to AppSyncClient's `subscribe` method to provide status updates. - Added verbose logging around subscription connections - Cancel streams and reconnect threads on disconnect
palpatim
force-pushed
the
palpatim/subscription-and-mqtt-fixes
branch
from
March 8, 2019 04:36
fdd8679
to
fc11da2
Compare
scb01
approved these changes
Mar 11, 2019
connectedCallback?() | ||
} | ||
|
||
func messageCallbackDelegate(data: Data) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method should include a check to validate that the subscription is not canceled.
let clientsWithNoTopics = self.removeClientsWithNoTopics() | ||
|
||
// Send the `disconnect` on the subscriptions queue since we don't need it for internal consistency | ||
self.subscriptionsQueue.async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider sending this work to a "utility" QOS dispatch queue.
This was referenced Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
statusChangeHandler
to AppSyncClient'ssubscribe
method to provide status updates.Issue #, if available:
#42
#184
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.