Add AppSyncClient.queuedMutationCount property #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed AppSyncMQTTClient data races (#184) - Added `statusChangeHandler` to AppSyncClient's `subscribe` method to provide status updates. - Added verbose logging around subscription connections - Cancel streams and reconnect threads on disconnect
This fixes the connection thrashing that can occur when the MQTT client reconnects while AppSync is simultaneously advising clients to reconnect. The preferred level at which to manage reconnections for AppSync is the AppSync client itself, rather than the MQTTClient. It's possible at some point in the future we may elect to expose an AppSync client to support auto-reconnect, but even that would still be managed in the AppSync client, rather than the MQTT client.
scb01
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#192
Description of changes:
NOTE: This PR is based on #197. See 9317952 for the diff that applies just to this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.