Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make network reachability provider mockable #245

Merged
merged 4 commits into from Apr 30, 2019
Merged

Make network reachability provider mockable #245

merged 4 commits into from Apr 30, 2019

Conversation

gleue
Copy link
Contributor

@gleue gleue commented Apr 29, 2019

Description of changes:

Merging this PR will make

  • initializer AWSAppSyncClient.init(appSyncConfig:reachabilityFactory:) public, and
  • protocols NetworkReachabilityProvidingFactory and NetworkReachabilityProviding public

which are all internal to the framework for now.

Rationale behind changes:

By allowing framework users access to above API it will be possible to

  • mock the reachability service properly for integration tests
  • substitute the reachability service with a private solution if already present in a project

Test results

The proposed changes have no effect on unit or integration tests. All tests succeed w/ changes
applied.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@palpatim palpatim added AppSync contribution Community contribution PRs labels Apr 29, 2019
@palpatim palpatim self-assigned this Apr 29, 2019
@palpatim palpatim merged commit 965f3cb into awslabs:master Apr 30, 2019
@palpatim
Copy link
Contributor

Thanks for the PR!

@gleue gleue deleted the feature/public-reachability-factory branch May 2, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Community contribution PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants