Make network reachability provider mockable #245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Merging this PR will make
AWSAppSyncClient.init(appSyncConfig:reachabilityFactory:)
public, andNetworkReachabilityProvidingFactory
andNetworkReachabilityProviding
publicwhich are all
internal
to the framework for now.Rationale behind changes:
By allowing framework users access to above API it will be possible to
Test results
The proposed changes have no effect on unit or integration tests. All tests succeed w/ changes
applied.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.