Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug which blocks subscription from starting after being cancelled. #251

Merged
merged 2 commits into from
May 8, 2019

Conversation

rohandubal
Copy link
Contributor

Issue #, if available:
#249

Description of changes:

  • Signal the semaphore from cancel method since we do not want to block any other subscriptions
  • Added unit test which validates the behavior
  • Added functional test which validates the behavior with actual subscription requests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rohandubal rohandubal added AppSync contribution Community contribution PRs labels May 8, 2019
@rohandubal rohandubal requested a review from palpatim May 8, 2019 16:59
@rohandubal rohandubal self-assigned this May 8, 2019
@rohandubal rohandubal merged commit 3bdc0c7 into master May 8, 2019
@rohandubal rohandubal deleted the rohandub/subs_restart_fix branch May 8, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Community contribution PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants