Fix strong retain cycles #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LachlanMcCulloch
force-pushed
the
fix-strong-retain-cycles
branch
from
997f6c6 to
955dd4f
Compare
LachlanMcCulloch
force-pushed
the
fix-strong-retain-cycles
branch
from
955dd4f to
f092722
Compare
|
Thanks for the speedy review @royjit ! Greatly appreciated!! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #342:
Description of changes:
Takes a
weak selfreference inside of the initial sync operation and dispatch timer for sync.The integration test
testDeltaSyncMetadataClearhad to be updated to take a strong reference of theCancellableobjects.The integration test
testStartStopStartSubscriptionsalso had to be updated, although this appeared to be failing previous to the changes provided here.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.