Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codable and Hashable to AWSAppSyncAuthType with tests #352

Merged

Conversation

LachlanMcCulloch
Copy link
Contributor

Issue #351 , if available:

Description of changes:
Add protocol conformance Hashable and Codable to AWSAppSyncAuthType, as well as unit tests for this new behaviour.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@LachlanMcCulloch LachlanMcCulloch force-pushed the add-decodable-to-awsauthtype branch from 8f62086 to 5cae70a Compare February 29, 2020 07:13
Copy link
Contributor

@lawmicha lawmicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@lawmicha lawmicha merged commit 95565b8 into awslabs:master Mar 5, 2020
@LachlanMcCulloch
Copy link
Contributor Author

Thanks @lawmicha !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants