AppSyncRealTimeClient ~> 1.1 + Cartfile fix #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
changed the title
royjit
approved these changes
Mar 16, 2020
palpatim
reviewed
Mar 16, 2020
| @@ -63,6 +63,8 @@ The AWS AppSync SDK for iOS enables you to access your AWS AppSync backend and p | |||
| * AWSCore.framework | |||
| * Reachability.framework | |||
| * SQLite.framework | |||
| * AppSyncRealTimeClient.framework | |||
| * Starscream.framework | |||
There was a problem hiding this comment.
Change "using Xcode 10.1" to "using Xcode 11". We should also add a new item to update the image to osx_image: xcode11.3 in .travis.yml, and then update README.md as appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AppSyncRealTimeClient Dependency to ~> 1.1
This is updated in both the cartfile and the podspec/podfile to take all minor versions from 1.1 up to and not including 2.0 of AppSyncRealTimeClient
cartfile fix
The Cartfile located at the root of the AppSyncClient repository is used when users run
carthage updateto determine which additional dependencies are needed. The reason for this is because AppSyncClient is managed by Cocoapods via Podfile. If AppSyncClient doesn't have a Cartfile, then the Carthage users in their projects containing a cartfile withgithub "awslabs/aws-mobile-appsync-sdk-ios"will just pull in AppSync source and build the AppSyncClient.framework and nothing else.Remove daltoniam/starscream for aws-amplify/aws-appsync-realtime-client-ios
Since aws-amplify/aws-appsync-realtime-client-ios itself is a repository that is managed by Pods, it also has a Cartfile indicating that it will need to pull in Starscream. So users pulling in aws-appsync-realtime-client-ios via cartfile will also pull in starscream.
Testing done
A new project with cartfile
github "awslabs/aws-mobile-appsync-sdk-ios" "feature/carthage"then
carthage update --platform iOSpulls in the required dependencies.Cartfile.resolved contains:
So this means carthage users installing awslabs/aws-mobile-appsync-sdk-ios get all the frameworks required, ie. taking a dependency on aws-amplify/aws-appsync-realtime-client-ios will pull in daltoniam/starscream
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.