AWSNetworkTransport modifications to enable the ability to mock server #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 26, 2018 11:07
…etwork responses. * Creating a protocol outlining the requirements for a NetworkTransport class * Modifiying internal dependecies on the concrete class, so they are only depedent on the protocol * Exposing a new configuration for app sync where the app can create their own network transport class.
|
Thanks for the PR @joelmbell ! I will review this shortly and get back to you. |
rohandubal
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #38
The purpose of this PR is to expose the NetworkTransport class that is used by the App Sync SDK so it is possible to create a Mock Network Transport object to control what responses from the server look like in our Functional UI tests.
Description of changes:
Creating a protocol outlining the requirements for a NetworkTransport class
Modifying internal dependecies on the concrete AWSAppSyncHTTPNetworkTransport class, so they are only depedent on the protocol
Exposing a new configuration initializer for app sync where the app can create their own network transport class. This includes a small refactor to the configuration class.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.