Fix bug in subscription where data is not translated correctly to a format valid for JSONSerialization #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat valid for JSONSerialization
|
Need to explore unit tests for this to ensure it doesn't break with various subscription input variable types |
|
Hi @LachlanMcCulloch, thanks for the PR. As mentioned above by @palpatim, I've added a few unit tests to capture the serialization scenario here LachlanMcCulloch#1 please have a look |
|
Big thanks @lawmicha , I really appreciate it! I have reviewed your tests and they look good to me. I'm happy to merge into my branch as soon as it suits you |
Add JSONSerializationTests for JSONValue bug
|
@lawmicha I have merged the MR in 🙂 |
lawmicha
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Issue 401
Description of changes:
See Issue for details
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.