Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SDK 2.16.0 #410

Merged
merged 3 commits into from
Sep 4, 2020
Merged

Upgrade to SDK 2.16.0 #410

merged 3 commits into from
Sep 4, 2020

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Sep 4, 2020

Issue #, if available:

Description of changes:
Upgrade to SDK 2.16.0

Testing done
Running unit test and integration test on Xcode 12

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lawmicha lawmicha changed the title Chore/upgrade sdk Upgrade to SDK 2.16.0 Sep 4, 2020
@lawmicha lawmicha marked this pull request as ready for review September 4, 2020 15:00
Copy link
Contributor

@palpatim palpatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I understand it, but do we know why the .xcconfig files for some pods were removed? Did you use the same version of CocoaPods to update the dependencies as we're going to be building with?

@lawmicha
Copy link
Contributor Author

lawmicha commented Sep 4, 2020

Looks good as far as I understand it, but do we know why the .xcconfig files for some pods were removed? Did you use the same version of CocoaPods to update the dependencies as we're going to be building with?

Ah this is because i did a re-install by removing existing Pods/ and Podfile.lock then pod install. I'm going to revert the commits and start over by just running pod cache clean --all && pod install --repo-update and it shouldn't delete those xcconfig files. I am using the same cocoapods version

@@ -1,4 +1,4 @@
github "aws/aws-sdk-ios" ~> 2.14.0
github "aws/aws-sdk-ios" ~> 2.16.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eek, thanks for catching this.

We keep missing dependencies in the Cartfile, though. We need a mechanism to double-check that the Cartfile deps match those in the Podfile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only ever bump this on minor version releases of the SDK, which is followed by an AppSync release so I got to this point from looking at the iOS release docs, and then over to the AppSync release docs. One place i can keep as a reminder is in the AppSync release docs, like "If this AppSync release is followed by the SDK minor release, do this" and have a reference to one of these PRs

@lawmicha lawmicha merged commit f1268ca into main Sep 4, 2020
@lawmicha lawmicha deleted the chore/upgrade-sdk branch September 4, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants