Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: carthage script defaults to build only #423

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Oct 15, 2020

Issue #, if available:
There was an error during release of 3.1.7 that can be reproduced locally:

$ bash ./build-support/carthage-build.sh archive AWSAppSync

*** xcodebuild output can be found in /var/folders/wl/yhpbkfx93g38l3k0ts5f92_1kgt2sf/T/carthage-xcodebuild.54QdZf.log
Failed to read file or folder at /Users/[USER]/awslabs/aws-mobile-appsync-sdk-ios/Cartfile.resolved: Error Domain=NSCocoaErrorDomain Code=260 "The file “Cartfile.resolved” couldn’t be opened because there is no such file." UserInfo={NSFilePath=/Users/[USER]/awslabs/aws-mobile-appsync-sdk-ios/Cartfile.resolved, NSUnderlyingError=0x7fb2a4524cb0 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}

Description of changes:
It looked like the carthage workaround script has hardcoded build, and our release script ran

bash ./build-support/carthage-build.sh archive $FRAMEWORK_NAME

so it was running

carthage build archive AWSAppSync

before having to introduce the carthage workaround script, we were doing carthage archive AWSAppSync

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lawmicha lawmicha requested a review from palpatim October 15, 2020 17:41
Copy link
Contributor

@palpatim palpatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that! Thanks for fixing.

@lawmicha lawmicha merged commit 6321e32 into main Oct 15, 2020
@lawmicha lawmicha deleted the fix/carthage-script branch October 15, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants