Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SDK 2.24.0 #472

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Update to SDK 2.24.0 #472

merged 1 commit into from
Apr 26, 2021

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Apr 25, 2021

Issue #, if available:

Description of changes:
Update to SDK 2.24.0

  • Integ test "AWSAppSync-IntegTests" target has passed
  • unit test has passsed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@@ -14,7 +14,7 @@ let package = Package(
.package(
name: "AWSiOSSDKV2",
url: "https://github.com/aws-amplify/aws-sdk-ios-spm.git",
.upToNextMinor(from: "2.23.3")
.upToNextMinor(from: "2.24.0")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like the cart file, we should be able to add this under the script

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was manually added right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will open separate PR for updating script

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait, it's already in the script, my bad

"revision": "9057509ddfc1f3ef1c36264e9b8e8173eda634c9",
"version": "2.23.3"
"revision": "7be6c13ea6fdcfdf54d50c08a10928e2e0bc3fb0",
"version": "2.24.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generated from swift package resolve

@lawmicha lawmicha requested review from royjit and diegocstn April 26, 2021 16:33
@lawmicha lawmicha marked this pull request as ready for review April 26, 2021 16:37
Copy link
Contributor

@royjit royjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -14,7 +14,7 @@ let package = Package(
.package(
name: "AWSiOSSDKV2",
url: "https://github.com/aws-amplify/aws-sdk-ios-spm.git",
.upToNextMinor(from: "2.23.3")
.upToNextMinor(from: "2.24.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was manually added right?

@lawmicha lawmicha merged commit e14237e into main Apr 26, 2021
@lawmicha lawmicha deleted the chore/upgrade-sdk-2.24.0 branch April 26, 2021 16:44
@lawmicha lawmicha mentioned this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants