-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to SDK 2.24.0 #472
Update to SDK 2.24.0 #472
Conversation
@@ -14,7 +14,7 @@ let package = Package( | |||
.package( | |||
name: "AWSiOSSDKV2", | |||
url: "https://github.com/aws-amplify/aws-sdk-ios-spm.git", | |||
.upToNextMinor(from: "2.23.3") | |||
.upToNextMinor(from: "2.24.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like the cart file, we should be able to add this under the script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was manually added right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, will open separate PR for updating script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait, it's already in the script, my bad
"revision": "9057509ddfc1f3ef1c36264e9b8e8173eda634c9", | ||
"version": "2.23.3" | ||
"revision": "7be6c13ea6fdcfdf54d50c08a10928e2e0bc3fb0", | ||
"version": "2.24.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generated from swift package resolve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -14,7 +14,7 @@ let package = Package( | |||
.package( | |||
name: "AWSiOSSDKV2", | |||
url: "https://github.com/aws-amplify/aws-sdk-ios-spm.git", | |||
.upToNextMinor(from: "2.23.3") | |||
.upToNextMinor(from: "2.24.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was manually added right?
Issue #, if available:
Description of changes:
Update to SDK 2.24.0
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.