feat: Upgrade AppSyncRealTimeClient 1.7.0 for Starscream 4 #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royjit
approved these changes
Feb 21, 2022
karim-alweheshy
pushed a commit
to chocoapp/aws-mobile-appsync-sdk-ios
that referenced
this pull request
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Setting the lowest version of AppSyncRealTimeClient to 1.7. When AppSync SDK is released and installed, it will pick up the starscream 4.0.4. Developers could explicitly upgrade AppSyncRT as well using older versions of AppSync SDK, however this way, developers only need to manage the AppSync SDK dependency if they do need to downgrade from starscream 4.0.4.
This PR sets it to 1.7 as the minimum, then will be released without any other changes. Although it is picking up AppSyncRT 1.8, the additive API in 1.8 is not used and can be pulled in as a non-breaking change to this SDK. There is a behavior change in the logging output, such that the default is
.errorso if pulling in 1.8 from AppSync SDK and need more verbose logs from AppSyncRTClient, the following can be used:Integration tests are passing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.