feat: Upgrade AppSyncRTClient 1.8.0 and enable logs #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruisebas
approved these changes
Feb 18, 2022
lawmicha
force-pushed
the
feat/appsync-loglevel
branch
from
798ba34 to
62862a2
Compare
lawmicha
force-pushed
the
feat/appsync-loglevel
branch
from
62862a2 to
3147fae
Compare
|
rebased and reran integration tests - all passing |
karim-alweheshy
pushed a commit
to chocoapp/aws-mobile-appsync-sdk-ios
that referenced
this pull request
Mar 24, 2022
* pod repo update * feat: Upgrade AppSyncRTClient 1.8.0 and enable logs * Set subscription log level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Because we are using
AppSyncRealTimeClient.logLevelwhich is introduced in 1.8, we should also set the minimum dependency on it to 1.8. This PR propagates the logLevel set when using AppSync SDK down to the logLevel of AppSyncRTClient.Developers using AppSync SDK uses the SDK's logging mechansim
AWSDDLog, ie.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.