fix: Thread safe subscription watcher cancel #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
force-pushed
the
fix/watcher-cancel
branch
from
b0f1b62 to
aa93d39
Compare
diegocstn
approved these changes
Feb 28, 2022
Comment on lines
182
to
187
| if !self.isCancelled { | ||
| if self.cancellationSource == .none { | ||
| self.cancellationSource = .user | ||
| } | ||
| self.performCleanUpTasksOnCancel() | ||
| } |
There was a problem hiding this comment.
nit: can we use a guard and an early return instead of nested ifs?
karim-alweheshy
pushed a commit
to chocoapp/aws-mobile-appsync-sdk-ios
that referenced
this pull request
Mar 24, 2022
* fix: Thread safe subscription watcher cancel * use guard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
If a connection is cancelled immediately after a subscribe, there may be a crash when accessing
connectionBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.