Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ReachabilitySwift from podspec and SPM #527

Merged
merged 2 commits into from
May 23, 2023

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Mar 7, 2022

Issue #, if available:

Description of changes:

Reachability was removed in #521

> pod spec lint

 -> AWSAppSync (3.6.0)
    - NOTE  | url: The URL (http://aws.amazon.com/mobile/sdk) is not reachable.
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | xcodebuild:  note: Build preparation complete
    - NOTE  | [iOS] xcodebuild:  note: Planning
    - NOTE  | [iOS] xcodebuild:  note: Building targets in dependency order
    - NOTE  | [iOS] xcodebuild:  Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.2.99. (in target 'Starscream' from project 'Pods')
    - NOTE  | [iOS] xcodebuild:  Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.2.99. (in target 'SQLite.swift' from project 'Pods')
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/Apollo/Sources/Apollo/ApolloClient.swift:5:30: warning: using 'class' keyword to define a class-constrained protocol is deprecated; use 'AnyObject' instead
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/Apollo/Sources/Apollo/ApolloStore.swift:7:33: warning: using 'class' keyword to define a class-constrained protocol is deprecated; use 'AnyObject' instead
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/Internal/AppSyncSubscriptionWithSync.swift:522:42: warning: 'hash' is deprecated: Use hashData instead.
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/AWSAppSyncHTTPNetworkTransport.swift:209:46: warning: 'hash' is deprecated: Use hashData instead.
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/Apollo/Sources/Apollo/GraphQLOperation.swift:1:35: warning: using 'class' keyword to define a class-constrained protocol is deprecated; use 'AnyObject' instead
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/Apollo/Sources/Apollo/GraphQLResultAccumulator.swift:1:43: warning: using 'class' keyword to define a class-constrained protocol is deprecated; use 'AnyObject' instead
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/NetworkReachability.swift:17:47: warning: using 'class' keyword to define a class-constrained protocol is deprecated; use 'AnyObject' instead

Analyzed 1 podspec.

[!] The spec did not pass validation, due to 7 warnings (but you can use `--allow-warnings` to ignore them).
> pod spec lint --allow-warnings

 -> AWSAppSync (3.6.0)
    - NOTE  | url: The URL (http://aws.amazon.com/mobile/sdk) is not reachable.
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | xcodebuild:  note: Build preparation complete
    - NOTE  | [iOS] xcodebuild:  note: Planning
    - NOTE  | [iOS] xcodebuild:  note: Building targets in dependency order
    - NOTE  | [iOS] xcodebuild:  Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.2.99. (in target 'Starscream' from project 'Pods')
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/Apollo/Sources/Apollo/ApolloClient.swift:5:30: warning: using 'class' keyword to define a class-constrained protocol is deprecated; use 'AnyObject' instead
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/Apollo/Sources/Apollo/ApolloStore.swift:7:33: warning: using 'class' keyword to define a class-constrained protocol is deprecated; use 'AnyObject' instead
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/Internal/AppSyncSubscriptionWithSync.swift:522:42: warning: 'hash' is deprecated: Use hashData instead.
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/AWSAppSyncHTTPNetworkTransport.swift:209:46: warning: 'hash' is deprecated: Use hashData instead.
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/Apollo/Sources/Apollo/GraphQLOperation.swift:1:35: warning: using 'class' keyword to define a class-constrained protocol is deprecated; use 'AnyObject' instead
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/Apollo/Sources/Apollo/GraphQLResultAccumulator.swift:1:43: warning: using 'class' keyword to define a class-constrained protocol is deprecated; use 'AnyObject' instead
    - WARN  | xcodebuild:  AWSAppSync/AWSAppSyncClient/NetworkReachability.swift:17:47: warning: using 'class' keyword to define a class-constrained protocol is deprecated; use 'AnyObject' instead
    - NOTE  | [iOS] xcodebuild:  Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.2.99. (in target 'SQLite.swift' from project 'Pods')

Analyzed 1 podspec.

AWSAppSync.podspec passed validation.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@royjit royjit requested a review from a team as a code owner May 19, 2023 21:12
@royjit royjit force-pushed the chore/remove-reachability branch from cf54cef to 43d1ead Compare May 19, 2023 21:14
@royjit royjit changed the title chore: remove ReachabilitySwift from podspec chore: remove ReachabilitySwift from podspec and SPM May 19, 2023
@royjit royjit merged commit a21429e into main May 23, 2023
@royjit royjit deleted the chore/remove-reachability branch May 23, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants