Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xcodeproj to recommended settings and fix warnings from XCode 10 build system #71

Merged
merged 7 commits into from
Sep 21, 2018

Conversation

mutablealligator
Copy link

Issue #, if available:

Description of changes:

  1. Updated xcodeproj file to the recommended build settings.
  2. Fix warnings from iOS 12 - XCode 10 build system
    2.1 Integer overflow
    2.2 Retaining self
    2.3 Non-exhaustive switch

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@rohandubal rohandubal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, could you add some information in the Changelog to call out XCode10 update?

@mutablealligator
Copy link
Author

@rohandubal Added CHANGELOG.

@rohandubal rohandubal merged commit f7abd42 into master Sep 21, 2018
@rohandubal rohandubal deleted the xcode-10 branch September 21, 2018 17:41
@frankmuellr frankmuellr added the contribution Community contribution PRs label Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Community contribution PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants