Added SubscriptionStatusObserver block to subscribe calls in AWSAppSyncClient #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yncClient, exposing all socket status. - Updated MQTTSubscriptionWatcher with new status property and delegate, deprecated unnecessary getIdentifier(), relying on the behaviour that MQTTSubscriptionWatcher is locked to be reference typed. - Replaced generic struct based AWSAppSyncSubscriptionError by a more descriptive enum based. - Updates MQTTClient tests
frankmuellr
added
feature-request
|
Hello @MarioBajr Thanks for this PR and sorry I have not been able to get to it. Exposing these many states might make it a bit complicated for everyone to use. We need to refine how we want to make this functionality available. I am closing this PR in favor of coming up with a spec discussion/ feature request on how to support this in #42 Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current AppSyncClient subscription API provides only callbacks to receive real time updates, but not enough to provide a better experience. The only callback that can be registered is the
resultHandler, which provides feedback from failure or the real time message package, not exposing basic connection status like if I managed to subscribe and just sits in the connected state waiting for updates, or if I'm still connecting, not being ready to receive real time updates.The goal of this PR is to expose the status of subscriptions, enabling clients to know when the system is ready to receive real time updates. Not only exposing all steps while establishing a connection but also all different types of errors.
Description of changes:
subscribemethod, requesting the closureSubscriptionStatusObserverthat will provide updates, and the propertystatusto theMQTTSubscriptionWatcherprotocol.getIdentifier(), relying on the behaviour thatMQTTSubscriptionWatcheris locked to be reference typed.AWSAppSyncSubscriptionErrorby a more descriptive enum based.Considerations:
This code deprecates:
MQTTSubscriptionWatcher.getIdentifierAWSAppSyncSubscriptionWatcher.uniqueIdentifierAWSAppSyncSubscriptionError.additionalInfoAWSAppSyncSubscriptionError.errorDetailsThis code removes:
class SubscriptionsOrderHelperBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.