Officially convert project to Swift 4.2 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the project used some Swift 4.2 idioms even though the SWIFT_VERSION was officially set to 3. This change makes the support explicit in both the project file and README.
…-swift-4.2 * origin/master: Fixed unstable subscription stress tests (#96)
rohandubal
approved these changes
Nov 15, 2018
rohandubal
pushed a commit
that referenced
this pull request
Nov 16, 2018
* Officially convert project to Swift 4.2 Previously, the project used some Swift 4.2 idioms even though the SWIFT_VERSION was officially set to 3. This change makes the support explicit in both the project file and README. * Updated CHANGELOG, fix invalid let binding in swizzle test helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the project used some Swift 4.2 idioms even though the
SWIFT_VERSION was officially set to 3. This change makes the support explicit
in both the project file and README.
Issue #, if available:
Following up on #84
Description of changes:
Updates SWIFT_VERSION to 4.2 in project and Podspec. Adds a
.swift-versionfile for Pod linting. Converted some deprecated uses.NOTE: I used Swift 3.0-style
@objcmigration. This will provide backward compatibility at the cost of not reducing binary size. Since there were only a couple of@objcannotations added during the migration, it's likely that the binary size savings would be minimal.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.