Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply clock skew interceptor to clients created via invoke #1285

Closed
wants to merge 2 commits into from

Conversation

ianbotsf
Copy link
Contributor

Issue #

Resolves #1211

Description of changes

This is a hackier, trimmed-down edition of smithy-lang/smithy-kotlin#1067 and #1284, which were deemed too breaking to apply without a minor version bump. This smaller fix adds additional codegen into each AWS service client to apply the clock skew interceptor.

This code should be removed and replaced with the above PRs when releasing version 1.2.0.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ianbotsf ianbotsf requested a review from a team as a code owner April 17, 2024 22:24
Copy link

A new generated diff is ready to view.

Copy link
Contributor

@0marperez 0marperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but CI is freaking out. I think it might be because the smithy kotlin version is outdated

Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

A new generated diff is ready to view.

@ianbotsf
Copy link
Contributor Author

Abandoned because proper fix was merged in #1297.

@ianbotsf ianbotsf closed this Apr 30, 2024
@ianbotsf ianbotsf deleted the fix-clockskew-application--hack-edition branch April 30, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clock skew interceptor is only applied when constructing clients via fromEnvironment
2 participants