refactor!: replace default HTTP client engine #554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
sibling: smithy-lang/smithy-kotlin#606
Description of changes
This PR swaps the default client HTTP engine from the CRT one to an opaque KMP compatible engine. The new default is one backed by Ktor/OkHttp. The existing CRT engine can still be used if desired but requires explicitly setting it.
Also in this PR is a modification of some of the e2e tests. The "big list of naughty" strings has been removed from S3 presign tests. These are not particularly representative of real object keys and are not recommended by S3 guidelines on object key naming. I've replaced it with a simpler test. We can add to this as needed. The presign tests now execute against the default and CRT engine to ensure we aren't introducing regressions across the HTTP engines we explicitly support.
Breaking Change
This change is technically not a breaking change in API but may result in a change in behavior or exceptions seen by users. If you wish to continue using the CRT based HTTP engine you can explicitly configure it:
implementation("aws.smithy.kotlin:http-client-engine-crt:0.7.9")
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.