Fixed a key name typo for Glue table properties for issue #184 (#185)

* initial commit for construct * initial commit for construct * adding a new construct * updates to construct default glue attributes * updating package.json * updating ts files * adding unit tests and integ tests * adding unit tests and integ tests * adding unit tests and helper methods to complete the construct * adding unit tests * adding unit tests * adding unit tests * fix for linting error * adding glue job example * update readme.md * update snapshots and kms arn * update description in package.json * integ test cases * added simulator for kinesis stream * added simulator for kinesis stream * integ test cases * updating construct for scriptlocation * updating python generator file * updating example code * updating example code * updating example code * updating example code * updating example code * updating example code * updating example code * update README and Architecture * updating README * updating README * updating construct * updating construct * updating construct * updating construct * updating construct * updating construct * updating construct * updating construct * updating construct * updating sample * updating construct * updating construct * updating construct * updating construct * updating sample * updating sample * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct kinesis policy * updating construct policy * updating readme * updated README * updated README * updated README * updated README * updated README * updated README * updated README * updated README * updated README * updates based on review * incoporating review comments * incoporating review comments * incoporating review comments * incoporating review comments * incoporating review comments * update to construct * update to construct * update to construct * update to construct * update to construct * update to construct * refactoring code to match construct patterns * refactoring code to match construct patterns * refactoring code to match construct patterns * refactoring code to match construct patterns * refactoring code to match construct patterns * refactoring code to match construct patterns * refactoring code to match construct patterns * fix for readme file * eslint fixes * update sample after refactoring construct * update sample after refactoring construct * remove _ from variable names * updating glue version 2.0 as recommended in Glue service documentation * removed snapshot (that was not required) to fix build failure * update viperlight to fix build issue * update viperlight to fix build issue * cfn_nag fix for build issues * updating integ snapshots * updating integ snapshots * update header * update header * incorporate publisher review comments * incorporate publisher review comments * incorporate publisher review comments * reorganization unitt tests * reorganization unitt tests * reorganization unitt tests * reorganization unitt tests * reorganization unitt tests * reorganization unitt tests * incorporate review comments * fix for output s3 bucket * fix for output s3 bucket * fix for output s3 bucket * update README with the correct class name * updating README * updates to readme * updates to readme * updates to readme * updates to readme * removing duplicate words from README * fix for bug #184 * fix for bug #184 * fix for bug #184 Co-authored-by: nihitkas <[email protected]>
awslabs · May 19, 2021 · 9812468 · 9812468
1 parent b0567e4
commit 9812468
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 18 deletions.
diff --git a/...cts/aws-kinesisstreams-gluejob/test/__snapshots__/test.kinesisstream-gluejob.test.js.snap b/...cts/aws-kinesisstreams-gluejob/test/__snapshots__/test.kinesisstream-gluejob.test.js.snap
@@ -188,7 +188,7 @@ Object {
         },
         "TableInput": Object {
           "Parameters": Object {
-            "classication": "json",
+            "classification": "json",
           },
           "StorageDescriptor": Object {
             "Columns": Array [
@@ -866,7 +866,7 @@ Object {
         },
         "TableInput": Object {
           "Parameters": Object {
-            "classication": "json",
+            "classification": "json",
           },
           "StorageDescriptor": Object {
             "Columns": Array [
@@ -1149,7 +1149,7 @@ Object {
         },
         "TableInput": Object {
           "Parameters": Object {
-            "classication": "json",
+            "classification": "json",
           },
           "StorageDescriptor": Object {
             "Columns": Array [
@@ -1787,7 +1787,7 @@ Object {
         },
         "TableInput": Object {
           "Parameters": Object {
-            "classication": "json",
+            "classification": "json",
           },
           "StorageDescriptor": Object {
             "Columns": Array [
@@ -2412,7 +2412,7 @@ Object {
         },
         "TableInput": Object {
           "Parameters": Object {
-            "classication": "json",
+            "classification": "json",
           },
           "StorageDescriptor": Object {
             "Columns": Array [
@@ -3063,7 +3063,7 @@ Object {
         },
         "TableInput": Object {
           "Parameters": Object {
-            "classication": "json",
+            "classification": "json",
           },
           "StorageDescriptor": Object {
             "Columns": Array [

diff --git a/...aws-solutions-constructs/aws-kinesisstreams-gluejob/test/integ.existing-job.expected.json b/...aws-solutions-constructs/aws-kinesisstreams-gluejob/test/integ.existing-job.expected.json
@@ -105,7 +105,7 @@
         },
         "TableInput": {
           "Parameters": {
-            "classication": "json"
+            "classification": "json"
           },
           "StorageDescriptor": {
             "Columns": [

diff --git a/...aws-solutions-constructs/aws-kinesisstreams-gluejob/test/integ.no-arguments.expected.json b/...aws-solutions-constructs/aws-kinesisstreams-gluejob/test/integ.no-arguments.expected.json
@@ -519,7 +519,7 @@
         },
         "TableInput": {
           "Parameters": {
-            "classication": "json"
+            "classification": "json"
           },
           "StorageDescriptor": {
             "Columns": [

diff --git a/...s-solutions-constructs/aws-kinesisstreams-gluejob/test/test.kinesisstream-gluejob.test.ts b/...s-solutions-constructs/aws-kinesisstreams-gluejob/test/test.kinesisstream-gluejob.test.ts
@@ -602,7 +602,7 @@ test('When database and table are not provided', () => {
       },
       TableInput: {
         Parameters: {
-          classication: "json"
+          classification: "json"
         },
         StorageDescriptor: {
           Columns: [

diff --git a/source/patterns/@aws-solutions-constructs/core/lib/glue-table-defaults.ts b/source/patterns/@aws-solutions-constructs/core/lib/glue-table-defaults.ts
@@ -14,7 +14,7 @@
 import * as glue from "@aws-cdk/aws-glue";
 import { Aws } from "@aws-cdk/core";
 
-export function DefaultGlueTableProps(database: glue.CfnDatabase, fieldSchema: glue.CfnTable.ColumnProperty [],
+export function DefaultGlueTableProps(database: glue.CfnDatabase, fieldSchema: glue.CfnTable.ColumnProperty[],
   sourceType?: string, parameters?: any): glue.CfnTableProps | any {
   let _tableProps: glue.CfnTableProps;
 
@@ -50,7 +50,7 @@ export function DefaultGlueTableProps(database: glue.CfnDatabase, fieldSchema: g
         },
         tableType: 'EXTERNAL_TABLE',
         parameters: {
-          classication: 'json'
+          classification: 'json'
         }
       }
     };

diff --git a/...e/patterns/@aws-solutions-constructs/core/test/__snapshots__/glue-job-helper.test.js.snap b/...e/patterns/@aws-solutions-constructs/core/test/__snapshots__/glue-job-helper.test.js.snap
@@ -63,7 +63,7 @@ Object {
         },
         "TableInput": Object {
           "Parameters": Object {
-            "classication": "json",
+            "classification": "json",
           },
           "StorageDescriptor": Object {
             "Columns": Array [
@@ -188,7 +188,7 @@ Object {
         },
         "TableInput": Object {
           "Parameters": Object {
-            "classication": "json",
+            "classification": "json",
           },
           "StorageDescriptor": Object {
             "Columns": Array [
@@ -645,7 +645,7 @@ Object {
         },
         "TableInput": Object {
           "Parameters": Object {
-            "classication": "json",
+            "classification": "json",
           },
           "StorageDescriptor": Object {
             "Columns": Array [
@@ -1117,7 +1117,7 @@ Object {
         },
         "TableInput": Object {
           "Parameters": Object {
-            "classication": "json",
+            "classification": "json",
           },
           "StorageDescriptor": Object {
             "Columns": Array [
@@ -1561,7 +1561,7 @@ Object {
         },
         "TableInput": Object {
           "Parameters": Object {
-            "classication": "json",
+            "classification": "json",
           },
           "StorageDescriptor": Object {
             "Columns": Array [

diff --git a/...patterns/@aws-solutions-constructs/core/test/__snapshots__/glue-table-helper.test.js.snap b/...patterns/@aws-solutions-constructs/core/test/__snapshots__/glue-table-helper.test.js.snap
@@ -24,7 +24,7 @@ Object {
         },
         "TableInput": Object {
           "Parameters": Object {
-            "classication": "json",
+            "classification": "json",
           },
           "StorageDescriptor": Object {
             "Columns": Array [

diff --git a/source/patterns/@aws-solutions-constructs/core/test/glue-table-helper.test.ts b/source/patterns/@aws-solutions-constructs/core/test/glue-table-helper.test.ts
@@ -121,7 +121,7 @@ test('Create table', () => {
       },
       TableInput: {
         Parameters: {
-          classication: "json"
+          classification: "json"
         },
         StorageDescriptor: {
           Columns: [