fix: ignore redirect statuses in Ktor engine #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
approved these changes
Feb 15, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
aws-sdk-kotlin#527
Description of changes
Ktor clients follow redirects by default. This causes problems because some services (e.g., S3) use redirects (e.g., HTTP 301) to indicate non-retryable errors yet do not include enough standardized information (e.g.,
Locationheader) to allow a client to actually redirect.This PR disables redirects in Ktor to allow the status code to bubble up to service-level error handling code and throw more actionable exceptions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.