Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore redirect statuses in Ktor engine #590

Merged
merged 2 commits into from
Feb 15, 2022
Merged

fix: ignore redirect statuses in Ktor engine #590

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb46712
fix: ignore redirect statuses in Ktor engine
ianbotsf Feb 14, 2022
5e6bde8
Merge branch 'main' into fix-ktor-engine-redirects
ianbotsf Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../http-client-engine-ktor/jvm/src/aws/smithy/kotlin/runtime/http/engine/ktor/KtorEngine.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@ actual class KtorEngine actual constructor(

// do not throw exceptions if status code < 300, error handling is expected by generated clients
expectSuccess = false

// do not attempt to follow redirects for status codes like 301 because they should be handled higher up
followRedirects = false
}

private val logger = Logger.getLogger<KtorEngine>()

// TODO: Remove following annotation after https://youtrack.jetbrains.com/issue/KTOR-3001 is resolved
Expand Down