-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evolution Pokémon #1371
base: master
Are you sure you want to change the base?
Evolution Pokémon #1371
Conversation
energyCost C | ||
attackRequirement { | ||
assert my.deck : "Your deck is empty" | ||
assert opp.all.find{it.evolution} : "Your opponent doesn't have any Evolved Pokémon in play" | ||
assert my.deck : "Your deck is empty" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did we remove the condition here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It moved into onAttack, so the attack can still be used if the opponent doesn't have any Evolutions in play, but it will just do nothing.
Side note, compulsory switch Drag Off should also work like this, but that's a problem for future me to solve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but why should we allow an attack to do nothing? in case that's a misplay, isn't that bad for the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but that's the way it works in the physical TCG. If your opponent misplays and tries to attack even though it will do nothing, you are within your rights to not allow them to take it back. Unlike Trainers, players can use attacks even though those attacks will have no effect.
One card that does make a difference between an attack that can't be used vs an attack that will do nothing is Holon Circle: if you're trying to break a Holon Circle with a Staryu that has a non-Water Energy attached, then having a Cosmic Draw that does nothing will let you do so (you declare the attack, then Holon Circle triggers and gets discarded), but having a Cosmic Draw that has an attack requirement will not (because you can't even declare the attack to begin with).
That said, I am OK with it staying as an attack requirement for user-friendliness. It's unlikely to matter much either way since neither Staryu nor Holon Circle are commonly played cards, so for it to manifest, not only would you need two players with rarely played cards in their decks matching against each other, the Staryu player would also need to be in a situation where he has a non-Water Energy attached, which puts it further in the realm of impossibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, do you want me to make the change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Some Gen 4 Pokémon incorrectly use "Evolved Pokémon" to refer to Evolution Pokémon. Only a few of them received official errata (the ones that refer to Stage 2s, i.e. Alakazam MT, Glalie MT, Staraptor SF).
Two of them (Dodrio MT and Flygon RR) have rulings on the Japanese FAQ page to confirm that they refer to Evolution Pokémon. This PR fixes those two, plus any others that don't have Japanese rulings, but use identical wording.
More info here.