Replace "it.dmg.value" with "it.notZero" for multiple damage modifiers applied before W/R, plus some other fixes in those code sections #942
Conversation
Reworked how some checks work.
* Intimidating Pattern/Fang/Pressure abilities are no longer ignored by swift attacks. It's an effect on the attacker, not on the defending Pokémon. * Minor logic changes in some cards.
|
Hi @flagrama could you review this one please? |
There was a problem hiding this comment.
Request to put a comment like
//Not checking for it.notNoEffect since it's applied before W/R, should count as an effect on the attacking pokemon.
Somewhere in the PR description or comments when it's done all over the place within the PR. 😆
Requesting a lot of bcs to be changed for consistency. If we want to clarify them at all, I think it'd be better to get them all at once so that a player doesn't get confused when some effects say it one way, and some say it the other.
A couple of questions about a few of the removed it.notNoEffects as well. Just need clarification that they are working as intended.
| before APPLY_ATTACK_DAMAGES, { | ||
| if (bg.currentTurn == self.owner){ | ||
| bg.dm().each { | ||
| if(it.to == defending && it.dmg.value && it.notNoEffect) { |
There was a problem hiding this comment.
It's definitely correct to do this even with an attack that ignores effects on the Defending Pokémon?
There was a problem hiding this comment.
I'd go with "it doesn't care", since it's an effect entirely within the defending Pokémon itself. It only cares about being damaged, doesn't affect the damage itself in any way.
As an example from Japan (couldn't find a good one in Compendium):
If, after playing the Supporter "Phoebe", I use my Pokémon VMAX attack and deal more damage than the HP of my opponent's Aggron with the "Sturdy" ability, will the opponent's Aggron be knocked out?
No, it will not.
In this case, the Aggron will remain in the field with 10 HP remaining.
As a similar case, a Reshiram&Charizard-GX using full-effect Double Blaze GX would still get 2 damage counters applied, if attacking a Pokémon with a Rocky Helmet attached.
Co-Authored-By: Vincent Cunningham <[email protected]>
|
Turning into draft as there's now many gen 4 sets implemented, which may need updates in this regard. |
Should eventually be turned into a ruleset-dependant single trainer for DP/HGSS/BW, but for now should work fine (HGSS original or errata usage is still not confirmed, for the HGSS block)
Should affect any damage, not only to owner's Pokémon.
These all include more substantial changes than just the replacement, so worth taking a separate peek for sure.
These can be applied to ef.attacker once, instead of for every single damage instance checked.
|
Hi @starg09 I hope you're well! Is there any chance for you to return and fix this one? :) btw, flagrama is already back! Cheers |
When finished, should fix some issues with cards such as "Darkness Energy vs Metal Energy" in wizards formats, or "Professor Kukui vs Pressure/Intimidating_Fang" in recent formats.
Counts as a mass replacement, so leaving a checklist for looked-around gens:
Sets not entirely fixable this way: