http2: allow port 80 in http2.connect

Due to how WHATWG-URL parser works, port numbers are omitted if they are the default port for a scheme. This meant that http2.connect could not accept connections on port 80 with http scheme. Fix this bug by detecting http: scheme and setting port to 80. PR-URL: nodejs/node#16337 Fixes: nodejs/node#14304 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
ayojs · Dec 7, 2017 · 3866b09 · 3866b09
1 parent cf71492
commit 3866b09
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -2419,7 +2419,8 @@ function connect(authority, options, listener) {
   debug(`connecting to ${authority}`);
 
   const protocol = authority.protocol || options.protocol || 'https:';
-  const port = '' + (authority.port !== '' ? authority.port : 443);
+  const port = '' + (authority.port !== '' ?
+    authority.port : (authority.protocol === 'http:' ? 80 : 443));
   const host = authority.hostname || authority.host || 'localhost';
 
   let socket;

diff --git a/test/parallel/test-http2-client-port-80.js b/test/parallel/test-http2-client-port-80.js
@@ -0,0 +1,19 @@
+'use strict';
+
+const common = require('../common');
+if (!common.hasCrypto)
+  common.skip('missing crypto');
+const assert = require('assert');
+const http2 = require('http2');
+const net = require('net');
+
+// Verifies that port 80 gets set as expected
+
+const connect = net.connect;
+net.connect = common.mustCall((...args) => {
+  assert.strictEqual(args[0], '80');
+  return connect(...args);
+});
+
+const client = http2.connect('http://localhost:80');
+client.destroy();