Fixed the encoding of some files #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the conversion! By curiosity, what kind of tools does it break :) ? |
|
@LordNoteworthy I was trying to generate rust bindings (using this). 😄 Unfortunately al-khaser is not really designed for the use as a library, since there are many functions, that'll just print the result instead of returning it. I'm not sure if changing these functions is something you'd want. If it is, I'm happy to submit another pull request. :) |
fengjixuchui
added a commit
to fengjixuchui/al-khaser
that referenced
this pull request
Apr 18, 2020
Merge pull request ayoubfaouzi#208 from not-matthias/master
|
ahh @not-matthias, rust binding to C libs :) Interesting! Indeed a lib might be useful for people who integrate al-khaser as a part of their QA testing. Atm I am trying to give some priority for the issues which are open. I will definitely think about it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the encoding of some files from
UTF-16toUTF-8, because this breaks some tools.