fixed a bug in LowFragmentationHeap #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoubfaouzi
reviewed
Sep 18, 2020
| // When running in a Win10 VM FrontEndHeap does not get initialized, | ||
| // so we get a null pointer dereferencing error. | ||
| if (FrontEndHeap == NULL) { | ||
| return TRUE; |
There was a problem hiding this comment.
Good catch! Shouldn't we return FALSE in this case ? Because this means we will return that the debugger was found any time somebody run the tool on Win10.
So maybe we can do something like:
if (FrontEndHeap && *FrontEndHeap == NULL) return TRUE;
There was a problem hiding this comment.
My bad! Fixed the fix.
|
Thanks a lot for the fix ! |
It's my pleasure to help a project that has helped me |
fengjixuchui
added a commit
to fengjixuchui/al-khaser
that referenced
this pull request
Oct 2, 2020
Merge pull request ayoubfaouzi#217 from rdzhaafar/LowFragmentation…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.