-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix + new anti-disassembly technique #245
Conversation
Hey @Yp3rion Thanks for your first contribution :) I will review this one today. |
That was a good catch ! I was wondering how did you track the problem back to the trap flag issue and I started debugging from there and I figured out that in the VEH handler, when we increase the instruction pointer, we end up returning right after the As a matter of fact, I also checked the x64 version and it does not need to advance RIP as well, you should get rid of it as it as well. I will look into the anti disassm tomorrow. Thank you. |
Perfect! I am happy to help and I was curious about the underlying issue since I have to admit I did not go much into detail after finding the bug, so thank you for explaining; I will make sure to fix the x64 version too then, should I do it after this pull request is approved or is it possible to edit a pull request on the fly? (I am a bit of a noob, I know) |
No worries, just modify the code, make a commit and push, it should appear here. |
Looks awesome ! Thank you again. |
Bugfix + new anti-disassembly technique (ayoubfaouzi#245)
The pull request deals with the following: