Fixed building with VS2019

[hasherezade]

While trying to build with Visual Studio 2019, the following errors occur:

The proposed patch makes the build successful:

[ayoubfaouzi]

Hey @hasherezade

Interesting, I can't reproduce it on my end, I have VS2019 (Community Edition) and it compiles without issues.

The VS project itself is made with VS 2017 but when you open it for the first time (depending on what you have on your machine) you get that dialog that asks you to migrate the project:

I myself have VS2019 which is backward compatible with previous VS back to 2010, but atm as you can see, we have the WindowsTargetPlatformVersion set to the sdk version 10.0.18362.0 and the PlatformToolset set to v141. On my setup, I the platformtoolset is set v141, and I don't get compilation errors. That's why it is not failing on my side :)

<WindowsTargetPlatformVersion>10.0.18362.0</WindowsTargetPlatformVersion>
  </PropertyGroup>
  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
    <ConfigurationType>Application</ConfigurationType>
    <UseDebugLibraries>true</UseDebugLibraries>
    <PlatformToolset>v141</PlatformToolset>

Probably one good thing to do is to set the WindowsTargetPlatformVersion to 10.0 which means use the latest Windows 10 SDK. And we can move the platform toolset to v142, that's probably most of what the people has now.

Cheers.

[ayoubfaouzi]

Wait :) I just got the same issue as you when making a fresh clone. If we use the platform toolset v142, it produces that issue. OK all good, merging your PR.

Thanks you !