[BUG] Pointer dereferencing issue with authentication (oss & pro)

[mathieucarbou]

When setting authentication, the function takes a pointer to username / password, and just holds a copy of the pointer in the class but not a copy of the data.

So when the pointer is dereferenced when the caller method finishes, the authenticate method of the HTTP GET handler does not work anymore.

I would suggest doing a safe copy of the data since it is used at another location and not only within the caller method context.

Otherwise, use String.

I've fixed it using String:

header:

private:
  [...]
  String username;
  String password;
  [...]

public:
  [...]
  void setAuthentication(const String &user, const String &pass);
  [...]

cpp

[...]

if(!request->authenticate(username.c_str(), password.c_str()))

[...]

void ESPDash::setAuthentication(const String &user, const String &pass) {
  username = user;
  password = pass;
  basic_auth = true;
  _ws->setAuthentication(username.c_str(), password.c_str());
}

[...]