Fixes and improvements

[mathieucarbou]

• Fix Allow to customise the home page url #165
• Fix [BUG] Pointer dereferencing issue with authentication (oss & pro) #166
• Fix Support Statistics.set(const char *value) - oss & pro #169
• Fix [BUG] No stat refresh - pro AND OSS #170
• Fix [BUG] _dashboard.sendUpdates(); is removing existing unchanged stats #172
• Fix Provide default value for Statistic constructor (oss & pro) #173
• FIx Support lib_compat_mode = strict #175

[mathieucarbou]

@ayushsharma82 : you'll need to update the CI GitHub workflow script to account for the change in library.json. I didn't do it because it depends on how you prefer to update it. The problem is that is currently uses a wrong board / platform to test the esp32 flavor.

[mathieucarbou]

If you want me to update according to what I think it should be, let me know.

[ayushsharma82]

@mathieucarbou Yeah I noticed. CI is using alpha release of ESP32 core. If you can modify the CI, it will be great and helpful!

[ayushsharma82]

I've changed the statistics update logic to now include their id in the object. The updated portal will use this ID to track changes just like cards and charts.

[ayushsharma82]

I did open a issue on arduino-ci by adafruit here: adafruit/ci-arduino#169 , I was referred to adafruit/ci-arduino#168 . Didn't really get time to do it myself. Just a quick reference for you.

[mathieucarbou]

I did open a issue on arduino-ci by adafruit here: adafruit/ci-arduino#169 , I was referred to adafruit/ci-arduino#168 . Didn't really get time to do it myself. Just a quick reference for you.

I will have a look.

But I tend to disagree with their move, because this should be up to the user to decide which platforms are used to test. I agree that using the latest is fine, but only in the use case of libraries part of a close ecosystem around teh framework and controlled by the same team. Their choice is weird because it impacts everybody would would like to stick with a specific version.

[ayushsharma82]

I did open a issue on arduino-ci by adafruit here: adafruit/ci-arduino#169 , I was referred to adafruit/ci-arduino#168 . Didn't really get time to do it myself. Just a quick reference for you.

I will have a look.

But I tend to disagree with their move, because this should be up to the user to decide which platforms are used to test. I agree that using the latest is fine, but only in the use case of libraries part of a close ecosystem around teh framework and controlled by the same team. Their choice is weird because it impacts everybody would would like to stick with a specific version.

I totally agree. They should have an option to select dev or stable releases. Till then I guess we will have to fork the CI and change that variable.

[ayushsharma82]

• Forked CI and using that fork in our github workflow now

[ayushsharma82]

@mathieucarbou Great everything checks out now! Can you test if the statistics are working as expected with the latest changes?

[mathieucarbou]

@mathieucarbou Great everything checks out now! Can you test if the statistics are working as expected with the latest changes?

yes! let me grab all that in my project. I am testing it now.

[mathieucarbou]

@mathieucarbou Great everything checks out now! Can you test if the statistics are working as expected with the latest changes?

yes! let me grab all that in my project. I am testing it now.

Note: also, please let me know when you'll issue a new pro release - I will download and test it. I am using both.

[mathieucarbou]

@ayushsharma82 : everything works fine in the OSS version.
Could you please port these changes to the pro version as well so that I can test ?
Thanks!

[ayushsharma82]

@mathieucarbou Released 4.3.0 of pro version just right now. Includes all the fixes and more exciting things as well.

[mathieucarbou]

thanks a lot !!!