Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore. Add hook OnSetArenaMinPlayersPerTeam #18579

Closed
wants to merge 1 commit into from

Conversation

pangolp
Copy link
Contributor

@pangolp pangolp commented Mar 18, 2024

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

Tests Performed:

This PR has been:

  • Tested in-game by the author. (I'm still doing tests)

How to Test the Changes:

  1. The idea of the change is to be able to add the minimum number of players so that the arena begins. It is intended for the mod-arena-3v3-solo-queue module but other modules may also use it at some point if they need it.

Known Issues and TODO List:

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added CORE Related to the core file-cpp Used to trigger the matrix build labels Mar 18, 2024
@pangolp pangolp requested a review from Helias March 18, 2024 20:07
@Helias Helias requested a review from Nyeriah March 18, 2024 20:51
@Elmsroth
Copy link
Contributor

Nice feature @pangolp <3

@pangolp
Copy link
Contributor Author

pangolp commented Mar 18, 2024

Nice feature @pangolp <3

We have to test, if it does not affect the current scoring system. Because I created it for the mod-arena-3v3-solo-queue module thinking that it could be used, but I don't know if I really need it. However, since we have OnSetArenaMaxPlayersPerTeam, it doesn't hurt that we also have OnSetArenaMinPlayersPerTeam. But you have to make sure that this modification does not affect the default behavior of the arenas.

@sudlud
Copy link
Member

sudlud commented Apr 20, 2024

I think this PR needs an update now to comply with the latest updates to the scripting system.

similar to how it is done in #18760.

@pangolp
Copy link
Contributor Author

pangolp commented Apr 21, 2024

I think this PR needs an update now to comply with the latest updates to the scripting system.

similar to how it is done in #18760.

Possibly, in the event of a merger, changes would have to be made. The issue is to know if it is really worth to merge it, because this hook was created for the 3v3 module, but I think that in the end it does not need it. If the module does not require it, and there is no other module that uses it, most likely, it will end up closing this pull request.

@pangolp pangolp removed request for Helias and Nyeriah April 24, 2024 13:01
@pangolp pangolp closed this May 5, 2024
@pangolp pangolp deleted the hook branch May 5, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE Related to the core file-cpp Used to trigger the matrix build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants